documentation overhaul (#353)

* ident
* remove $Id$ tags from rcs software which has been retired
* make an effort to sync required mib docs with actual code
* sync even more docs with what code actually does
* some whitespace nits
* fixup example to use snmpv2 for all but the most ancient devices
* remove blurb to find more specific snmp::info classes for classes
  which alrdy are as specific as they can get (eg snmp::info::layer3::vmware
  doesn't need info on to find a specific module since there ain't none)
* rename all sub {vendor} strings to lowercase vendor, if cisco, juniper
  and arista can be lowercase, so can be all the rest.
* fix tests
* spread some use warnings around
* use $ instead of @
* remove defines that are included via parent classes
* use strict + warnings
* remove alrdy included modules
* add comma after last list item
* typos
* mibs are found in our mib repo, not on the cisco site
* documentation fixes

lib/SNMP/Info/Layer7/APC.pm

@@ -31,6 +31,7 @@
 package SNMP::Info::Layer7::APC;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;
 
@@ -133,11 +134,6 @@ Jeroen van Ingen
 Provides abstraction to the configuration information obtainable from a
 APC UPS via SNMP.
 
-For speed or debugging purposes you can call the subclass directly, but not
-after determining a more specific class using the method above.
-
- my $apc = new SNMP::Info::Layer7::APC(...);
-
 =head2 Inherited Classes
 
 =over

lib/SNMP/Info/Layer7/Arbor.pm

@@ -30,6 +30,7 @@
 package SNMP::Info::Layer7::Arbor;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;
 
@@ -153,11 +154,11 @@ These are methods that return scalar value from SNMP
 
 =item $Arbor->vendor()
 
-Returns 'Arbor'.
+Returns 'arbor'.
 
 =item $Arbor->os()
 
-Returns 'arbos'.
+Returns 'ArbOS'.
 
 =item $Arbor->os_ver()
 

lib/SNMP/Info/Layer7/CiscoIPS.pm

@@ -1,5 +1,4 @@
 # SNMP::Info::Layer7::CiscoIPS
-# $Id$
 #
 # Copyright (c) 2013 Moe Kraus
 # All rights reserved.
@@ -213,7 +212,7 @@ Returns model name
 
 =item $info->productname
 
-Retruns the product name
+Returns the product name
 
 =item $info->serial
 

lib/SNMP/Info/Layer7/Gigamon.pm

@@ -30,6 +30,7 @@
 package SNMP::Info::Layer7::Gigamon;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;
 

lib/SNMP/Info/Layer7/Liebert.pm

@@ -30,6 +30,7 @@
 package SNMP::Info::Layer7::Liebert;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;
 
@@ -90,7 +91,7 @@ Netdisco Developers
                           Debug       => 1,
                           DestHost    => 'myhub',
                           Community   => 'public',
-                          Version     => 1
+                          Version     => 2
                         )
     or die "Can't connect to DestHost.\n";
 

lib/SNMP/Info/Layer7/Neoteris.pm

@@ -30,6 +30,7 @@
 package SNMP::Info::Layer7::Neoteris;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;
 

lib/SNMP/Info/Layer7/Netscaler.pm

@@ -30,6 +30,7 @@
 package SNMP::Info::Layer7::Netscaler;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer7;