documentation overhaul (#353)

* ident
* remove $Id$ tags from rcs software which has been retired
* make an effort to sync required mib docs with actual code
* sync even more docs with what code actually does
* some whitespace nits
* fixup example to use snmpv2 for all but the most ancient devices
* remove blurb to find more specific snmp::info classes for classes
  which alrdy are as specific as they can get (eg snmp::info::layer3::vmware
  doesn't need info on to find a specific module since there ain't none)
* rename all sub {vendor} strings to lowercase vendor, if cisco, juniper
  and arista can be lowercase, so can be all the rest.
* fix tests
* spread some use warnings around
* use $ instead of @
* remove defines that are included via parent classes
* use strict + warnings
* remove alrdy included modules
* add comma after last list item
* typos
* mibs are found in our mib repo, not on the cisco site
* documentation fixes

xt/lib/Test/SNMP/Info.pm

@@ -29,6 +29,8 @@
 
 package Test::SNMP::Info;
 
+use strict;
+use warnings;
 use Test::Class::Most parent => 'My::Test::Class';
 
 use SNMP::Info;

xt/lib/Test/SNMP/Info/Layer2/3Com.pm

@@ -83,7 +83,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), '3Com', q(Vendor returns '3Com'));
+  is($test->{info}->vendor(), '3com', q(Vendor returns '3com'));
 }
 
 sub model : Tests(3) {

xt/lib/Test/SNMP/Info/Layer2/Aironet.pm

@@ -122,7 +122,6 @@ sub description : Tests(4) {
 
   $test->{info}{_description} = undef;
   $expected = 'Cisco Aironet 1240 Series (IEEE 802.11a/g) Access Point';
-  $expected .= '  ';
   is($test->{info}->description(), $expected, q(Description is expected value just using Entity MIB));
 
   $test->{info}->clear_cache();

xt/lib/Test/SNMP/Info/Layer2/Kentrox.pm

@@ -52,7 +52,7 @@ sub os : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'os');
-  is($test->{info}->os(), 'Kentrox', q(OS returns 'Kentrox'));
+  is($test->{info}->os(), 'kentrox', q(OS returns 'kentrox'));
 }
 
 sub os_ver : Tests(3) {
@@ -80,7 +80,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Kentrox', q(Vendor returns 'Kentrox'));
+  is($test->{info}->vendor(), 'kentrox', q(Vendor returns 'kentrox'));
 }
 
 sub model : Tests(3) {

xt/lib/Test/SNMP/Info/Layer2/Ubiquiti.pm

@@ -61,8 +61,8 @@ sub vendor : Tests(2) {
   can_ok($test->{info}, 'vendor');
   is(
     $test->{info}->vendor(),
-    'Ubiquiti Networks, Inc.',
-    q(Vendor returns 'Ubiquiti Networks, Inc.')
+    'ubiquiti',
+    q(Vendor returns 'ubiquiti')
   );
 }
 

xt/lib/Test/SNMP/Info/Layer3/BlueCoatSG.pm

@@ -63,7 +63,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Blue Coat', q(Vendor returns 'Blue Coat'));
+  is($test->{info}->vendor(), 'bluecoat', q(Vendor returns 'bluecoat'));
 }
 
 sub model : Tests(2) {

xt/lib/Test/SNMP/Info/Layer3/Cumulus.pm

@@ -62,7 +62,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Cumulus Networks', q(Vendor returns 'Cumulus Networks'));
+  is($test->{info}->vendor(), 'cumulus networks', q(Vendor returns 'cumulus networks'));
 }
 
 sub os : Tests(2) {

xt/lib/Test/SNMP/Info/Layer3/ERX.pm

@@ -77,7 +77,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Juniper', q(Vendor returns 'Juniper'));
+  is($test->{info}->vendor(), 'juniper', q(Vendor returns 'juniper'));
 }
 
 sub model : Tests(3) {

xt/lib/Test/SNMP/Info/Layer3/Huawei.pm

@@ -117,7 +117,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Huawei', q(Vendor returns 'Huawei'));
+  is($test->{info}->vendor(), 'huawei', q(Vendor returns 'huawei'));
 }
 
 sub os : Tests(3) {

xt/lib/Test/SNMP/Info/Layer3/Pica8.pm

@@ -62,7 +62,7 @@ sub vendor : Tests(2) {
   my $test = shift;
 
   can_ok($test->{info}, 'vendor');
-  is($test->{info}->vendor(), 'Pica8', q(Vendor returns 'Pica8'));
+  is($test->{info}->vendor(), 'pica8', q(Vendor returns 'pica8'));
 }
 
 sub model : Tests(3) {