From 42db01335ea31293d8d6d56e4c9656463cb712bd Mon Sep 17 00:00:00 2001 From: "Eric A. Miller" Date: Mon, 16 Apr 2018 23:47:35 -0400 Subject: [PATCH] Add Layer3::ERX test class and POD updates --- Changes | 1 + MANIFEST | 1 + META.json | 8 +-- META.yml | 6 +- README | 5 ++ lib/SNMP/Info.pm | 6 ++ lib/SNMP/Info/Layer3/ERX.pm | 4 ++ xt/lib/Test/SNMP/Info/Layer3/ERX.pm | 92 +++++++++++++++++++++++++++++ 8 files changed, 116 insertions(+), 7 deletions(-) create mode 100644 xt/lib/Test/SNMP/Info/Layer3/ERX.pm diff --git a/Changes b/Changes index e28e73a8..d1203222 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,7 @@ Version 3.55 [NEW FEATURES] + * #259 Add ERX (Old Juniper E-Series JunOSe) Support (robwwd) * #258 Add support for Arbor devices (robwwd) * #253 Nexans switch support (paecker) * #142 Sixnet Switch Support diff --git a/MANIFEST b/MANIFEST index 7de9bb74..335d8e41 100644 --- a/MANIFEST +++ b/MANIFEST @@ -227,6 +227,7 @@ xt/lib/Test/SNMP/Info/Layer3/Cumulus.pm xt/lib/Test/SNMP/Info/Layer3/Dell.pm xt/lib/Test/SNMP/Info/Layer3/DLink.pm xt/lib/Test/SNMP/Info/Layer3/Enterasys.pm +xt/lib/Test/SNMP/Info/Layer3/ERX.pm xt/lib/Test/SNMP/Info/Layer3/Extreme.pm xt/lib/Test/SNMP/Info/Layer3/F5.pm xt/lib/Test/SNMP/Info/Layer3/Force10.pm diff --git a/META.json b/META.json index 859d604d..39e2d35d 100644 --- a/META.json +++ b/META.json @@ -363,14 +363,14 @@ "file" : "lib/SNMP/Info/Layer3/Dell.pm", "version" : "3.54" }, - "SNMP::Info::Layer3::Enterasys" : { - "file" : "lib/SNMP/Info/Layer3/Enterasys.pm", - "version" : "3.54" - }, "SNMP::Info::Layer3::ERX" : { "file" : "lib/SNMP/Info/Layer3/ERX.pm", "version" : "3.54" }, + "SNMP::Info::Layer3::Enterasys" : { + "file" : "lib/SNMP/Info/Layer3/Enterasys.pm", + "version" : "3.54" + }, "SNMP::Info::Layer3::Extreme" : { "file" : "lib/SNMP/Info/Layer3/Extreme.pm", "version" : "3.54" diff --git a/META.yml b/META.yml index 1da8d778..cf06e038 100644 --- a/META.yml +++ b/META.yml @@ -259,12 +259,12 @@ provides: SNMP::Info::Layer3::Dell: file: lib/SNMP/Info/Layer3/Dell.pm version: '3.54' - SNMP::Info::Layer3::Enterasys: - file: lib/SNMP/Info/Layer3/Enterasys.pm - version: '3.54' SNMP::Info::Layer3::ERX: file: lib/SNMP/Info/Layer3/ERX.pm version: '3.54' + SNMP::Info::Layer3::Enterasys: + file: lib/SNMP/Info/Layer3/Enterasys.pm + version: '3.54' SNMP::Info::Layer3::Extreme: file: lib/SNMP/Info/Layer3/Extreme.pm version: '3.54' diff --git a/README b/README index dd6bc140..90c50603 100644 --- a/README +++ b/README @@ -671,6 +671,11 @@ SUBCLASSES See documentation in SNMP::Info::Layer3::Enterasys for details. + SNMP::Info::Layer3::ERX + Subclass for Juniper ERX switches. + + See documentation in SNMP::Info::Layer3::ERX for details. + SNMP::Info::Layer3::Extreme Subclass for Extreme Networks switches. diff --git a/lib/SNMP/Info.pm b/lib/SNMP/Info.pm index c1a852d2..fbb9b75a 100644 --- a/lib/SNMP/Info.pm +++ b/lib/SNMP/Info.pm @@ -804,6 +804,12 @@ Subclass for Enterasys devices. See documentation in L for details. +=item SNMP::Info::Layer3::ERX + +Subclass for Juniper ERX switches. + +See documentation in L for details. + =item SNMP::Info::Layer3::Extreme Subclass for Extreme Networks switches. diff --git a/lib/SNMP/Info/Layer3/ERX.pm b/lib/SNMP/Info/Layer3/ERX.pm index 1d788a2a..709f5199 100644 --- a/lib/SNMP/Info/Layer3/ERX.pm +++ b/lib/SNMP/Info/Layer3/ERX.pm @@ -143,6 +143,10 @@ Subclass for Juniper ERX switches =back +=head2 Required MIBs + +=over + =item Inherited Classes' MIBs See L for its own MIB requirements. diff --git a/xt/lib/Test/SNMP/Info/Layer3/ERX.pm b/xt/lib/Test/SNMP/Info/Layer3/ERX.pm new file mode 100644 index 00000000..7372fe11 --- /dev/null +++ b/xt/lib/Test/SNMP/Info/Layer3/ERX.pm @@ -0,0 +1,92 @@ +# Test::SNMP::Info::Layer3::ERX +# +# Copyright (c) 2018 Rob Woodward +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are met: +# +# * Redistributions of source code must retain the above copyright notice, +# this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# * Neither the name of the University of California, Santa Cruz nor the +# names of its contributors may be used to endorse or promote products +# derived from this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE +# LIABLE FOR # ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +# POSSIBILITY OF SUCH DAMAGE. + +package Test::SNMP::Info::Layer3::ERX; + +use Test::Class::Most parent => 'My::Test::Class'; + +use SNMP::Info::Layer3::ERX; + +# Remove this startup override once we have full method coverage +sub startup : Tests(startup => 1) { + my $test = shift; + $test->SUPER::startup(); + + $test->todo_methods(1); +} + +sub setup : Tests(setup) { + my $test = shift; + $test->SUPER::setup; + + # Start with a common cache that will serve most tests + my $cache_data = { + '_layers' => 76, + '_description' => 'Juniper Networks, Inc. ERX-1400 Edge Routing Switch SW Version : (12.3.2 patch-0.1 [BuildId 14534]) Build Date : August 13, 2012 12:31 Copyright (c) 1999, 2001 Juniper Networks, Inc.', + '_id' => '.1.3.6.1.4.1.4874.1.1.1.1.1', + 'store' => {}, + }; + $test->{info}->cache($cache_data); +} + +sub os : Tests(2) { + my $test = shift; + + can_ok($test->{info}, 'os'); + is($test->{info}->os(), 'JunOSe', q(OS returns 'JunOSe')); +} + +sub os_ver : Tests(3) { + my $test = shift; + + can_ok($test->{info}, 'os_ver'); + is($test->{info}->os_ver(), '12.3.2 patch-0.1 [BuildId 14534]', q(OS version has expected value)); + + $test->{info}->clear_cache(); + is($test->{info}->os_ver(), undef, + q(No description returns undef OS version)); +} + +sub vendor : Tests(2) { + my $test = shift; + + can_ok($test->{info}, 'vendor'); + is($test->{info}->vendor(), 'Juniper', q(Vendor returns 'Juniper')); +} + +sub model : Tests(3) { + my $test = shift; + + can_ok($test->{info}, 'model'); + is($test->{info}->model(), 'ERX-1400', q(Model has expected value)); + + $test->{info}->clear_cache(); + is($test->{info}->model(), undef, q(No description returns undef model)); +} +1;