redlion cellular router (sn / ram series) support (#333)

Changes

@@ -1,5 +1,9 @@
 Version 3.68 (2019-xx-xx)
 
+  [NEW FEATURES]
+
+  * initial support for redlion cellular routers (inphobia)
+
   [ENHANCEMENTS]
 
   * use pulsesecure mib in layer7::neoteris instead of juniper-ive

MANIFEST

@@ -118,6 +118,7 @@ lib/SNMP/Info/Layer3/PaloAlto.pm
 lib/SNMP/Info/Layer3/Passport.pm
 lib/SNMP/Info/Layer3/Pf.pm
 lib/SNMP/Info/Layer3/Pica8.pm
+lib/SNMP/Info/Layer3/Redlion.pm
 lib/SNMP/Info/Layer3/SonicWALL.pm
 lib/SNMP/Info/Layer3/Steelhead.pm
 lib/SNMP/Info/Layer3/Sun.pm
@@ -264,6 +265,7 @@ xt/lib/Test/SNMP/Info/Layer3/PaloAlto.pm
 xt/lib/Test/SNMP/Info/Layer3/Passport.pm
 xt/lib/Test/SNMP/Info/Layer3/Pf.pm
 xt/lib/Test/SNMP/Info/Layer3/Pica8.pm
+xt/lib/Test/SNMP/Info/Layer3/Redlion.pm
 xt/lib/Test/SNMP/Info/Layer3/SonicWALL.pm
 xt/lib/Test/SNMP/Info/Layer3/Steelhead.pm
 xt/lib/Test/SNMP/Info/Layer3/Sun.pm

META.json

@@ -4,7 +4,7 @@
       "Eric A. Miller <emiller@cpan.org>"
    ],
    "dynamic_config" : 1,
-   "generated_by" : "Module::Build version 0.4229",
+   "generated_by" : "Module::Build version 0.4224",
    "license" : [
       "bsd"
    ],
@@ -490,6 +490,10 @@
          "file" : "lib/SNMP/Info/Layer3/Pica8.pm",
          "version" : "3.67"
       },
+      "SNMP::Info::Layer3::Redlion" : {
+         "file" : "lib/SNMP/Info/Layer3/Redlion.pm",
+         "version" : "3.67"
+      },
       "SNMP::Info::Layer3::SonicWALL" : {
          "file" : "lib/SNMP/Info/Layer3/SonicWALL.pm",
          "version" : "3.67"
@@ -591,5 +595,5 @@
       "x_MailingList" : "https://lists.sourceforge.net/lists/listinfo/snmp-info-users"
    },
    "version" : "3.67",
-   "x_serialization_backend" : "JSON::PP version 2.97001"
+   "x_serialization_backend" : "JSON::PP version 4.02"
 }

META.yml

@@ -17,7 +17,7 @@ build_requires:
 configure_requires:
   Module::Build: '0.42'
 dynamic_config: 1
-generated_by: 'Module::Build version 0.4229, CPAN::Meta::Converter version 2.150010'
+generated_by: 'Module::Build version 0.4224, CPAN::Meta::Converter version 2.150010'
 license: bsd
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -354,6 +354,9 @@ provides:
   SNMP::Info::Layer3::Pica8:
     file: lib/SNMP/Info/Layer3/Pica8.pm
     version: '3.67'
+  SNMP::Info::Layer3::Redlion:
+    file: lib/SNMP/Info/Layer3/Redlion.pm
+    version: '3.67'
   SNMP::Info::Layer3::SonicWALL:
     file: lib/SNMP/Info/Layer3/SonicWALL.pm
     version: '3.67'

lib/SNMP/Info.pm

@@ -991,6 +991,12 @@ Subclass for Pica8 devices.
 
 See documentation in L<SNMP::Info::Layer3::Pica8> for details.
 
+=item SNMP::Info::Layer3::Redlion
+
+Subclass for redlion routers.
+
+See documentation in L<SNMP::Info::Layer3::Redlion> for details.
+
 =item SNMP::Info::Layer3::SonicWALL
 
 Subclass for generic SonicWALL devices.
@@ -1653,6 +1659,7 @@ sub device_type {
         674  => 'SNMP::Info::Layer3::Dell',
         1588 => 'SNMP::Info::Layer3::Foundry',
         1872 => 'SNMP::Info::Layer3::AlteonAD',
+        1890 => 'SNMP::Info::Layer3::Redlion',
         1916 => 'SNMP::Info::Layer3::Extreme',
         1991 => 'SNMP::Info::Layer3::Foundry',
         2011 => 'SNMP::Info::Layer3::Huawei',
@@ -1711,6 +1718,7 @@ sub device_type {
         664   => 'SNMP::Info::Layer2::Adtran',
         674   => 'SNMP::Info::Layer3::Dell',
         1872  => 'SNMP::Info::Layer3::AlteonAD',
+        1890  => 'SNMP::Info::Layer3::Redlion',
         1916  => 'SNMP::Info::Layer3::Extreme',
         1991  => 'SNMP::Info::Layer3::Foundry',
         2011  => 'SNMP::Info::Layer3::Huawei',

lib/SNMP/Info/Layer3/Redlion.pm

@@ -0,0 +1,197 @@
+package SNMP::Info::Layer3::Redlion;
+#
+# Copyright (c) 2019 nick nauwelaerts
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#     * Redistributions of source code must retain the above copyright notice,
+#       this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above copyright
+#       notice, this list of conditions and the following disclaimer in the
+#       documentation and/or other materials provided with the distribution.
+#     * Neither the name of the University of California, Santa Cruz nor the
+#       names of its contributors may be used to endorse or promote products
+#       derived from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+# LIABLE FOR # ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+
+use strict;
+use warnings;
+
+use Exporter;
+use SNMP::Info::Layer3;
+
+@SNMP::Info::Layer3::Redlion::ISA = qw/
+    SNMP::Info::Layer3
+    Exporter
+/;
+@SNMP::Info::Layer3::Redlion::EXPORT_OK = qw//;
+
+our ($VERSION, %GLOBALS, %MIBS, %FUNCS, %MUNGE);
+
+$VERSION = '3.67';
+
+%MIBS = (
+    %SNMP::Info::Layer3::MIBS,
+    'RED-LION-RAM-MIB' => 'unitDescription',
+);
+
+%GLOBALS = (
+    %SNMP::Info::Layer3::GLOBALS,
+    'sn_model'  => 'unitDescription',
+    'sn_os_ver' => 'unitFirmwareVersion',
+    'sn_serial' => 'unitSerialNumber',
+);
+
+%FUNCS = (
+    %SNMP::Info::Layer3::FUNCS,
+);
+
+%MUNGE = (
+    %SNMP::Info::Layer3::MUNGE,
+);
+
+sub layers {
+    return '00000110';
+}
+
+sub vendor {
+    return 'redlion';
+}
+
+sub os_ver {
+    my $redlion = shift;
+
+    return $redlion->sn_os_ver();
+}
+
+sub model {
+    my $redlion = shift;
+
+    return $redlion->sn_model();
+}
+
+sub serial {
+    my $redlion = shift;
+
+    return $redlion->sn_serial();
+}
+
+# is actually just an embedded linux
+# 'sn' refers to "sixnet", the original creators of the device
+# layer2::sixnet is for redlion's switch offerings.
+# (they also have a different enterprise oid)
+sub os {
+    return 'sn';
+}
+
+1;
+
+__END__
+
+=head1 NAME
+
+SNMP::Info::Layer3::Redlion - SNMP Interface to redlion routers
+
+=head1 AUTHORS
+
+nick nauwelaerts
+
+=head1 SYNOPSIS
+
+    # Let SNMP::Info determine the correct subclass for you.
+    my $redlion = new SNMP::Info(
+                          AutoSpecify => 1,
+                          Debug       => 1,
+                          DestHost    => 'myrouter',
+                          Community   => 'public',
+                          Version     => 2
+                        )
+    or die "Can't connect to DestHost.\n";
+
+    my $class      = $redlion->class();
+    print "SNMP::Info determined this device to fall under subclass : $class\n";
+
+=head1 DESCRIPTION
+
+Subclass for redlion routers.
+
+=head2 Inherited Classes
+
+=over
+
+=item SNMP::Info::Layer3
+
+=back
+
+=head2 Required MIBs
+
+=over
+
+=item F<RED-LION-RAM-MIB>
+
+=back
+
+=head2 Inherited MIBs
+
+See L<SNMP::Info::Layer3/"Required MIBs"> for its MIB requirements.
+
+=head1 GLOBALS
+
+These are methods that return scalar value from SNMP.
+
+=over
+
+=item $redlion->layers()
+
+Returns '00000110' since sysServices returns undef.
+
+=item $redlion->model()
+
+Returns the model extracted from C<unitDescription>.
+
+=item $redlion->os()
+
+Returns 'sn'.
+
+=item $redlion->os_ver()
+
+Returns the os version extracted from C<unitFirmwareVersion>.
+
+=item $redlion->serial()
+
+Returns the serial extracted from C<unitSerialNumber>. Must be enabled
+in the snmp setup of the device to show this.
+
+=item $redlion->vendor()
+
+Returns 'redlion'.
+
+=back
+
+=head2 Global Methods imported from SNMP::Info::Layer3
+
+See L<SNMP::Info::Layer3/"GLOBALS"> for details.
+
+=head1 TABLE ENTRIES
+
+These are methods that return tables of information in the form of a reference
+to a hash.
+
+=head2 Table Methods imported from SNMP::Info::Layer3
+
+See L<SNMP::Info::Layer3/"TABLE METHODS"> for details.
+
+=cut

xt/lib/Test/SNMP/Info/Layer3/Redlion.pm

@@ -0,0 +1,106 @@
+# Test::SNMP::Info::Layer3::Redlion
+#
+# Copyright (c) 2019 nick nauwelaerts
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#     * Redistributions of source code must retain the above copyright notice,
+#       this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above copyright
+#       notice, this list of conditions and the following disclaimer in the
+#       documentation and/or other materials provided with the distribution.
+#     * Neither the name of the University of California, Santa Cruz nor the
+#       names of its contributors may be used to endorse or promote products
+#       derived from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+# LIABLE FOR # ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+
+package Test::SNMP::Info::Layer3::Redlion;
+
+use strict;
+use warnings;
+
+use Test::Class::Most parent => 'My::Test::Class';
+
+use SNMP::Info::Layer3::Redlion;
+
+sub setup : Tests(setup) {
+  my $test = shift;
+  $test->SUPER::setup;
+
+  # Start with a common cache that will serve most tests
+  my $cache_data = {
+    '_layers'          => 6,
+    '_description'     => 'Linux hostname 2.6.39 #1 Fri Dec 8 18:57:40 UTC 2017 armv5tejl',
+    '_id'              => '.1.3.6.1.4.1.1890',
+    '_sn_serial'       => '682X55900000000',
+    '_sn_model'        => 'SN-6921',
+    '_sn_os_ver'       => '4.28.95.0',
+    'store'            => {},
+  };
+  $test->{info}->cache($cache_data);
+}
+
+sub layers : Tests(2) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'layers');
+  is($test->{info}->layers(), '00000110', q(layers returns '00000110'));
+}
+
+sub os : Tests(2) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'os');
+  is($test->{info}->os(), 'sn', q(OS returns 'sn'));
+}
+
+sub os_ver : Tests(3) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'os_ver');
+  is($test->{info}->os_ver(), '4.28.95.0', q(OS version has expected value));
+
+  $test->{info}->clear_cache();
+  is($test->{info}->os_ver(), undef,
+    q(No os version returns undef));
+}
+
+sub vendor : Tests(2) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'vendor');
+  is($test->{info}->vendor(), 'redlion', q(vendor returns 'redlion'));
+}
+
+sub model : Tests(2) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'model');
+  is($test->{info}->model(), 'SN-6921', q(model has expected value));
+}
+
+sub serial : Tests(3) {
+  my $test = shift;
+
+  can_ok($test->{info}, 'serial');
+  is($test->{info}->serial(), '682X55900000000', q(serial has expected value));
+
+  $test->{info}->clear_cache();
+  is($test->{info}->serial(), undef,
+    q(No serial returns undef));
+}
+
+1;