From a54b446dae8938bdbd2cb42fd74dc853216b54d1 Mon Sep 17 00:00:00 2001 From: Brian De Wolf Date: Thu, 23 Jun 2011 13:51:43 -0700 Subject: [PATCH] Avoid Perl warnings in Info::CiscoStack These two points in CiscoStack use a value from a hash in a numerical comparison without verifying they exist. If they don't, Perl warnings get emitted. Instead, we check for existence first, then compare the value. --- Info/CiscoStack.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Info/CiscoStack.pm b/Info/CiscoStack.pm index a190b385..7807d81a 100644 --- a/Info/CiscoStack.pm +++ b/Info/CiscoStack.pm @@ -159,7 +159,7 @@ sub i_duplex { next if ( defined $partial and $iid !~ /^$partial$/ ); # Test for gigabit - if ( $p_duplex_cap->{$port} == 0 ) { + if ( $p_duplex_cap->{$port} && $p_duplex_cap->{$port} == 0 ) { $i_duplex->{$iid} = 'full'; } @@ -194,7 +194,7 @@ sub i_duplex_admin { next if ( defined $partial and $iid !~ /^$partial$/ ); # Test for gigabit - if ( $p_duplex_cap->{$port} == 0 ) { + if ( $p_duplex_cap->{$port} && $p_duplex_cap->{$port} == 1 ) { $i_duplex_admin->{$iid} = 'full'; }