pod cleanup

This commit is contained in:
inphobia
2019-01-19 05:55:28 +01:00
parent 19cdb388e5
commit a59572b392
19 changed files with 33 additions and 87 deletions

View File

@@ -35,7 +35,7 @@ sub check_version {
# Make sure that this package is listed in Info.pm
fail($_) unless $content =~ m/^\s*package\s+(\S+)\s*;/m;
my $package = $1;
return if $package eq 'SNMP::Info';

View File

@@ -20,12 +20,12 @@ Net-SNMP not found. Net-SNMP installs the perl modules SNMP and
SNMP::Session.
Versions 4.2.1 to 5.3 the Perl modules are not distributed on CPAN, you must
install from the distribution.
install from the distribution.
Install Net-SNMP from http://net-snmp.sourceforge.net and make sure you run
configure with the --with-perl-modules switch!
Note to Redhat Users: Redhat, in its infinite wisdom, does not install the
Note to Redhat Users: Redhat, in its infinite wisdom, does not install the
Perl modules as part of their 8.0 RPMS. Please uninstall them and install the
newest version by hand.
@@ -48,20 +48,20 @@ SKIP: {
my ($ver_maj,$ver_min,$ver_rev) = split(/\./,$VERSION);
ok ($ver_maj >= 4, 'Net-SNMP ver 4 or higher');
if ($ver_maj == 4 and $ver_min == 2 and $ver_rev == 0){
print STDERR << "end_420";
SNMP module version 4.2.0 found. Please triple check that you have
version 4.2.0 of Net-SNMP installed, and that you did not accidently install
the SNMP module found on CPAN. All newer versions are bundled with
Net-SNMP, and are not available on CPAN. Please find them at
http://net-snmp.sourceforge.net . Make sure you run configure with the
the SNMP module found on CPAN. All newer versions are bundled with
Net-SNMP, and are not available on CPAN. Please find them at
http://net-snmp.sourceforge.net . Make sure you run configure with the
--with-perl-modules switch.
end_420
}
if( $ver_maj == 5 and $ver_min == 0 and $ver_rev == 1 ){
print STDERR << "end_501";
@@ -71,7 +71,7 @@ Perl module of Net-SNMP 5.0.1 is buggy. Please upgrade.
end_501
}
if(( $ver_maj == 5 and $ver_min == 3 and $ver_rev == 1 ) or
( $ver_maj == 5 and $ver_min == 2 and $ver_rev == 3 )) {
print STDERR << "end_bulkwalk";
@@ -81,13 +81,13 @@ Perl module of Net-SNMP Versions 5.3.1 and 5.2.3 have issues with bulkwalk,
turn off bulkwalk. Please upgrade.
end_bulkwalk
}
}
}
print STDERR << "end_mibs";
Make sure you download and install the MIBS needed for SNMP::Info.
Make sure you download and install the MIBS needed for SNMP::Info.
See Man page or perldoc for SNMP::Info.
end_mibs

View File

@@ -463,7 +463,7 @@ sub ip_index : Tests(4) {
can_ok($test->{info}, 'ip_index');
my $cache_data = {
'_old_ip_index' => 1,
'_old_ip_index' => 1,
'_new_ip_index' => 1,
'_new_ip_type' => 1,
'store' => {
@@ -498,7 +498,7 @@ sub ip_table : Tests(4) {
can_ok($test->{info}, 'ip_table');
my $cache_data = {
'_old_ip_table' => 1,
'_old_ip_table' => 1,
'_new_ip_index' => 1,
'_new_ip_type' => 1,
'store' => {
@@ -533,7 +533,7 @@ sub ip_netmask : Tests(4) {
can_ok($test->{info}, 'ip_netmask');
my $cache_data = {
'_old_ip_netmask' => 1,
'_old_ip_netmask' => 1,
'_new_ip_prefix' => 1,
'_new_ip_type' => 1,
'store' => {
@@ -908,7 +908,7 @@ sub resolve_desthost : Tests(6) {
'udp6:fe80:0:0:0:2d0:b7ff:fe21:c6c0',
q(Net-SNMP example IPv6 address returns with 'udp6:' prefix)
);
dies_ok { SNMP::Info::resolve_desthost('1.2.3.4.5') } 'Bad IP dies';
}

View File

@@ -60,7 +60,7 @@ sub qb_fdb_index : Tests(3) {
my $test = shift;
can_ok( $test->{info}, 'qb_fdb_index' );
my $expected = { 0 => 1, 3 => 91, 1 => 112, 2 => 113 };
cmp_deeply( $test->{info}->qb_fdb_index(), $expected, q(FDB to VLAN index returned expected values));

View File

@@ -377,9 +377,9 @@ sub lldp_cap : Tests(4) {
can_ok($test->{info}, 'lldp_cap');
my $expected = ['bridge', 'router'];
my $caps = $test->{info}->lldp_cap();
cmp_set($caps->{'0.6.1'}, $expected,
q(Caps emumerated correctly));

View File

@@ -74,7 +74,7 @@ sub setup : Tests(setup) {
2 => '802.11G Radio',
3 => '802.11A Radio',
4 => 'PowerPCElvis Ethernet',
},
},
},
};

View File

@@ -78,7 +78,7 @@ sub model : Tests(5) {
$test->{info}{_id} = '.100.3.6.1.4.1.20540.2.1';
is($test->{info}->model(), '.100.3.6.1.4.1.20540.2.1',
q(Model is expected value when id doesn't translate));
$test->{info}->clear_cache();
is($test->{info}->model(), undef, q(No data returns undef model));
}

View File

@@ -44,7 +44,7 @@ sub startup : Tests(startup => 1) {
sub setup : Tests(setup) {
my $test = shift;
$test->SUPER::setup;
# Start with a common cache that will serve most tests
my $d_string = 'Arista Networks EOS version 4.10.4 ';
$d_string .= 'running on an Arista Networks DCS-7048T-A';

View File

@@ -43,7 +43,7 @@ sub setup : Tests(setup) {
'_peth_port_class' => 1,
'store' => {
'peth_port_status' => {'1.1' => 'searching', '1.3' => 'otherFault', '1.24' => 'deliveringPower'},
'peth_port_class' => {'1.1' => 'class0', '1.3' => 'class0', '1.24' => 'class3'},
'peth_port_class' => {'1.1' => 'class0', '1.3' => 'class0', '1.24' => 'class3'},
},
};
$test->{info}->cache($cache_data);
@@ -80,4 +80,4 @@ sub peth_port_neg_power : Tests(3) {
{}, q(No data returns empty hash));
}
1;
1;