clean scalance

a few typos
info::bridge & info::lldp get pulled in via info::layer3
use Socket could be dropped in favor of resolve_desthost(), but needs testing.

(not tested waiting for what travis says)
This commit is contained in:
nick n
2020-11-14 20:13:47 +01:00
committed by GitHub
parent e2544129bc
commit babbbb4e57

View File

@@ -40,18 +40,13 @@ package SNMP::Info::Layer3::Scalance;
use strict;
use warnings;
use Exporter;
use Socket;
use SNMP::Info::Layer3;
use SNMP::Info::MAU;
use SNMP::Info::LLDP;
use SNMP::Info::Bridge;
use Socket;
use Data::Dumper;
@SNMP::Info::Layer3::Scalance::ISA = qw/
SNMP::Info::Layer3
SNMP::Info::MAU
SNMP::Info::Bridge
SNMP::Info::LLDP
Exporter
/;
@SNMP::Info::Layer3::Scalance::EXPORT_OK = qw//;
@@ -63,8 +58,6 @@ $VERSION = '3.70';
%MIBS = (
%SNMP::Info::Layer3::MIBS,
%SNMP::Info::MAU::MIBS,
%SNMP::Info::LLDP::MIBS,
%SNMP::Info::Bridge::MIBS,
'SN-MSPS-SCX-MIB' => 'snMsps',
'AUTOMATION-SYSTEM-MIB' => 'automationManufacturerId',
);
@@ -72,8 +65,6 @@ $VERSION = '3.70';
%GLOBALS = (
%SNMP::Info::Layer3::GLOBALS,
%SNMP::Info::MAU::GLOBALS,
%SNMP::Info::LLDP::GLOBALS,
%SNMP::Info::Bridge::GLOBALS,
'serial1' => 'automationSerialNumber.0',
'ps1_status' => 'snMspsPowerSupply1State.0',
'ps2_status' => 'snMspsPowerSupply2State.0',
@@ -83,16 +74,12 @@ $VERSION = '3.70';
%FUNCS = (
%SNMP::Info::Layer3::FUNCS,
%SNMP::Info::MAU::FUNCS,
%SNMP::Info::LLDP::FUNCS,
%SNMP::Info::Bridge::FUNCS,
);
%MUNGE = (
# Inherit all the built in munging
%SNMP::Info::Layer3::MUNGE,
%SNMP::Info::MAU::MUNGE,
%SNMP::Info::LLDP::MUNGE,
%SNMP::Info::Bridge::MUNGE,
);
sub layers {
@@ -206,7 +193,7 @@ Christoph Handel
Provides abstraction to the configuration information obtainable from a
Siemens Scalance Switch via SNMP.
Tested only with sclance xr524
Tested only with scalance xr524
=head2 Inherited Classes
@@ -216,22 +203,13 @@ Tested only with sclance xr524
=item SNMP::Info::MAU
=item SNMP::Info::LLDP
=item SNMP::Info::Bridge
=back
=head2 Required MIBs
=over
=item F<SN-MSPS-SCX-MIB>
=item F<AUTOMATION-SYSTEM-MIB>
=item F<AUTOMATION-SMI.txt>
=item F<AUTOMATION-SMI>
=item F<AUTOMATION-SYSTEM-MIB>
@@ -239,6 +217,8 @@ Tested only with sclance xr524
=item F<SIEMENS-SMI>
=item F<SN-MSPS-SCX-MIB>
=back
L<https://support.industry.siemens.com/cs/document/22015045/private-mibs%3A-scalance-x-scalance-w-and-snmp-opc-profile?dti=0&lc=en-DE>
@@ -268,7 +248,7 @@ Returns siemens
=item $scalance->model()
extrace a meaningful name from description
extract a meaningful name from description
=item $scalance->mac()