Prevent potential undefined warning in ports() of Layer3::C3550

Add Layer3::C3550 test class
This commit is contained in:
Eric A. Miller
2018-04-11 20:30:46 -04:00
parent 02e6807e44
commit c515a5e4a1
2 changed files with 178 additions and 2 deletions

View File

@@ -96,8 +96,8 @@ sub ports {
my $c3550 = shift; my $c3550 = shift;
my $id = $c3550->id(); my $id = $c3550->id();
my $model = &SNMP::translateObj($id); my $model = SNMP::translateObj($id);
if ( $model =~ /(12|24|48)(C|T|TS|G|TS-E|TS-S|T-E)?$/ ) { if ( defined $model && $model =~ /(12|24|48)(C|T|TS|G|TS-E|TS-S|T-E)?$/ ) {
return $1; return $1;
} }

View File

@@ -0,0 +1,176 @@
# Test::SNMP::Info::Layer3::C3550
#
# Copyright (c) 2018 Eric Miller
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
#
# * Redistributions of source code must retain the above copyright notice,
# this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# * Neither the name of the University of California, Santa Cruz nor the
# names of its contributors may be used to endorse or promote products
# derived from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
# LIABLE FOR # ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.
package Test::SNMP::Info::Layer3::C3550;
use Test::Class::Most parent => 'My::Test::Class';
use SNMP::Info::Layer3::C3550;
sub setup : Tests(setup) {
my $test = shift;
$test->SUPER::setup;
# Start with a common cache that will serve most tests
my $d_string = 'Cisco IOS Software, C3550 Software (C3550-IPSERVICESK9-M), ';
$d_string .= 'Version 12.2(35)SE, RELEASE SOFTWARE (fc2)';
my $cache_data = {
'_layers' => 6,
'_description' => $d_string,
# CISCO-PRODUCTS-MIB::catalyst355012T
'_id' => '.1.3.6.1.4.1.9.1.368',
'_ports' => 22,
'_el_duplex' => 1,
'_p_port' => 1,
'_p_duplex' => 1,
'_p_duplex_admin' => 1,
'_p_speed' => 1,
'store' => {
'el_duplex' => {
'2' => 'fullDuplex',
'3' => 'halfDuplex',
'4' => 'fullDuplex',
'26' => 'fullDuplex'
},
'p_port' => {'0.1' => 2, '0.2' => 3, '0.3' => 4, '2.1' => 26},
'p_duplex' =>
{'0.1' => 'auto', '0.2' => 'half', '0.3' => 'full', '2.1' => 'auto'},
'p_duplex_admin' => {
'0.1' => pack("H*", 'E0'),
'0.2' => pack("H*", 'E0'),
'0.3' => pack("H*", 'E0'),
'2.1' => pack("H*", '00'),
},
'p_speed' => {
'0.1' => 'autoDetect',
'0.2' => 's100000000',
'0.3' => 's100000000',
'2.1' => 'autoDetect',
},
},
};
$test->{info}->cache($cache_data);
}
sub vendor : Tests(2) {
my $test = shift;
can_ok($test->{info}, 'vendor');
is($test->{info}->vendor(), 'cisco', q(Vendor returns 'cisco'));
}
sub model : Tests(2) {
my $test = shift;
can_ok($test->{info}, 'model');
is($test->{info}->model(), '3550-12T', q(Model is expected value));
}
sub ports : Tests(4) {
my $test = shift;
can_ok($test->{info}, 'ports');
is($test->{info}->ports(), '12', q(Expected number of ports));
delete $test->{info}{_id};
is($test->{info}->ports(), '22', q(Expected number of ports using ifNumber));
$test->{info}->clear_cache();
is($test->{info}->ports(), undef, q(No data returns undef));
}
sub i_duplex : Tests(4) {
my $test = shift;
can_ok($test->{info}, 'i_duplex');
my $expected = {2 => 'full', 3 => 'half', 4 => 'full', 26 => 'full'};
cmp_deeply($test->{info}->i_duplex(),
$expected, q(Interfaces have expected duplex values using etherlike));
delete $test->{info}{_el_duplex};
delete $test->{info}{store}{el_duplex};
$expected = {3 => 'half', 4 => 'full', 26 => 'full'};
cmp_deeply($test->{info}->i_duplex(),
$expected, q(Interfaces have expected duplex values using ciscostack));
$test->{info}->clear_cache();
cmp_deeply($test->{info}->i_duplex(),
{}, q(No duplex data returns empty hash));
}
sub i_duplex_admin : Tests(4) {
my $test = shift;
can_ok($test->{info}, 'i_duplex_admin');
my $expected = {2 => 'auto', 3 => 'half', 4 => 'full', 26 => 'auto'};
cmp_deeply($test->{info}->i_duplex_admin(),
$expected, q(Interfaces have expected duplex admin values using etherlike));
delete $test->{info}{_el_duplex};
delete $test->{info}{store}{el_duplex};
$expected = {2 => 'auto', 3 => 'half', 4 => 'full', 26 => 'full'};
cmp_deeply($test->{info}->i_duplex_admin(),
$expected,
q(Interfaces have expected duplex admin values using ciscostack));
$test->{info}->clear_cache();
cmp_deeply($test->{info}->i_duplex_admin(),
{}, q(No duplex admin data returns empty hash));
}
sub set_i_duplex_admin : Tests(3) {
my $test = shift;
# Set method uses a partial fetch which ignores the cache and reloads data
# therefore we must use the mocked session.
my $data = {
'EtherLike-MIB::dot3StatsDuplexStatus' => {
'1' => 'fullDuplex',
'2' => 'halfDuplex',
'3' => 'fullDuplex',
'26' => 'fullDuplex'
},
};
$test->{info}{sess}{Data} = $data;
can_ok($test->{info}, 'set_i_duplex_admin');
is($test->{info}->set_i_duplex_admin('full', 2),
1, q(Mock set duplex call succeeded));
is($test->{info}->set_i_duplex_admin('full-x', 2),
0, q(Mock set duplex call to bad duplex type 'full-x' fails));
}
1;