From cdafa791d0c4e3c22d0c65c872675b697d02d83e Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Mon, 20 Feb 2023 15:32:37 +0000 Subject: [PATCH] #464 check in case non numeric key in cache befor inc --- lib/SNMP/Info.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/SNMP/Info.pm b/lib/SNMP/Info.pm index 48de238a..e1a34322 100644 --- a/lib/SNMP/Info.pm +++ b/lib/SNMP/Info.pm @@ -15,6 +15,7 @@ use strict; use Exporter; use SNMP; use Carp; +use Scalar::Util (); use Math::BigInt; use NetAddr::IP::Lite ':lower'; @@ -4924,6 +4925,11 @@ sub _cache { my $store = $self->store(); if (ref {} eq ref $data) { + if (! Scalar::Util::looks_like_number($self->{"_${attr}"}) { + # https://github.com/netdisco/snmp-info/issues/464 + # perhaps this is being set twice and first time gets $data ?? + $self->{"_${attr}"} = 0; + } $self->{"_${attr}"}++; $store->{$attr} = $data; }