Fix for Perl::Critic flagged warning

This commit is contained in:
Eric A. Miller
2013-02-10 12:38:16 -05:00
parent 8f0ac35381
commit d4c460fd3d

View File

@@ -433,32 +433,40 @@ sub i_ssidlist {
my $partial = shift; my $partial = shift;
my $apif_bssid = $nwss2300->nwss2300_apif_bssid($partial) || {}; my $apif_bssid = $nwss2300->nwss2300_apif_bssid($partial) || {};
my $i_index = $nwss2300->i_index($partial) || {}; my $i_index = $nwss2300->i_index($partial) || {};
my %i_ssidlist; my %i_ssidlist;
foreach my $iid ( keys %$i_index ) { foreach my $iid ( keys %$i_index ) {
# Skip non-radio interfaces # Skip non-radio interfaces
next if $iid =~ /^\d+$/; next if $iid =~ /^\d+$/;
foreach my $idx ( keys %$apif_bssid) { foreach my $idx ( keys %$apif_bssid ) {
next unless ($idx =~ /^$iid\./); next unless ( $idx =~ /^$iid\./ );
my $bssid_mac = $apif_bssid->{$idx}; my $bssid_mac = $apif_bssid->{$idx};
next unless $bssid_mac; next unless $bssid_mac;
# Give the SSID a numeric value based upon tail of BSSID # Give the SSID a numeric value based upon tail of BSSID
my $id = hex $1 if $bssid_mac =~ /:([0-9A-F]{1,2})$/i; my $id;
next unless (defined $id and $id =~ /\d+/); if ( $bssid_mac =~ /:([0-9A-F]{1,2})$/i ) {
$id = hex $1;
}
next unless ( defined $id and $id =~ /\d+/ );
my $ssid_oid = $idx; my $ssid_oid = $idx;
$ssid_oid =~ s/^$iid\.//; $ssid_oid =~ s/^$iid\.//;
my $ssid = join( '', map { sprintf "%c", $_ } split /\./, $ssid_oid ); my $ssid
= join( '', map { sprintf "%c", $_ } split /\./, $ssid_oid );
# Remove any control characters including nulls # Remove any control characters including nulls
$ssid =~ s/[\c@-\c_]//g; $ssid =~ s/[\c@-\c_]//g;
$i_ssidlist{"$iid.$id"} = $ssid; $i_ssidlist{"$iid.$id"} = $ssid;
} }
} }
return \%i_ssidlist; return \%i_ssidlist;
} }
# Can't find in MIB # Can't find in MIB
# #
#sub i_ssidbcast { #sub i_ssidbcast {