135/snmp-info
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- PBP - never modify $_ in list functions

Browse Source 
- PBP - use named lexicals as explicit for loop iterators
This commit is contained in:
Eric Miller
2008-07-09 02:27:39 +00:00
parent 4e6a452c87
commit daa0162639
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Info/Layer2/Aironet.pm
View File

@@ -265,8 +265,11 @@ sub i_vlan {
# 5.5Mbps is reported as 11. # 5.5Mbps is reported as 11.
sub munge_cd11_txrate { sub munge_cd11_txrate {
my $txrates = shift; my $txrates = shift;
my @rates = unpack("C*", $txrates); my @units = unpack("C*", $txrates);
map {$_ *= 0.5} @rates; my @rates = map {
my $unit = $_;
$unit *= 0.5;
} @units;
return \@rates; return \@rates;
} }
@@ -315,7 +318,6 @@ sub i_mac {
my $aironet = shift; my $aironet = shift;
# no partial is possible due to the levels # no partial is possible due to the levels
# of indirection. # of indirection.
my $idx;
# Start with the ifPhysAddress, and override # Start with the ifPhysAddress, and override
my $mbss_mac = $aironet->orig_i_mac(); my $mbss_mac = $aironet->orig_i_mac();
@@ -326,13 +328,13 @@ sub i_mac {
my $ifstack = $aironet->ifStackStatus(); my $ifstack = $aironet->ifStackStatus();
my $vlan_list = {}; my $vlan_list = {};
foreach $idx (keys %$vlan_map) { foreach my $idx (keys %$vlan_map) {
my ($vlan, $num) = split(/\./, $idx); my ($vlan, $num) = split(/\./, $idx);
push(@{$vlan_list->{$vlan}}, $vlan_map->{$idx}); push(@{$vlan_list->{$vlan}}, $vlan_map->{$idx});
} }
my $stack = {}; my $stack = {};
foreach $idx (keys %$ifstack) { foreach my $idx (keys %$ifstack) {
my ($upper, $lower) = split(/\./, $idx); my ($upper, $lower) = split(/\./, $idx);
$stack->{$upper}->{$lower} = $ifstack->{$idx}; $stack->{$upper}->{$lower} = $ifstack->{$idx};
} }