From dd982373a7b6ebac9857409ee2496263232781e8 Mon Sep 17 00:00:00 2001
From: nick n <39005454+inphobia@users.noreply.github.com>
Date: Tue, 6 Jul 2021 21:49:50 +0200
Subject: [PATCH] fix tests (#428)

* add arubacx, replace unicode backtick

* fix pod

* remove undef, is implicit in scalar context. fixes tests

* mention IEEE802_Bridge
---
 lib/SNMP/Info.pm                |  8 +++++++-
 lib/SNMP/Info/Layer3/ArubaCX.pm | 20 ++++++++++++++++----
 lib/SNMP/Info/Layer3/Ciena.pm   | 16 ++++++++++++++++
 3 files changed, 39 insertions(+), 5 deletions(-)

diff --git a/lib/SNMP/Info.pm b/lib/SNMP/Info.pm
index dbea24d2..008be2ee 100644
--- a/lib/SNMP/Info.pm
+++ b/lib/SNMP/Info.pm
@@ -747,6 +747,12 @@ Subclass for Aruba wireless switches.
 
 See documentation in L<SNMP::Info::Layer3::Aruba> for details.
 
+=item SNMP::Info::Layer3::ArubaCX
+
+SNMP Interface to L3 Devices running ArubaOS-CX
+
+See documentation in L<SNMP::Info::Layer3::ArubaCX> for details.
+
 =item SNMP::Info::Layer3::BayRS
 
 Subclass for Avaya/Nortel/Bay Multiprotocol/BayRS routers.  This includes
@@ -5035,7 +5041,7 @@ sub can {
     # We could add load_/orig_/_raw alternatives to symbol table here on
     # first call of any type for a global or func since they all use the same
     # destination code, but they aren't used heavily in main code base so
-    # we’ll just create if/when they are called rather than pollute the
+    # we'll just create if/when they are called rather than pollute the
     # symbol table with entries that never get called.
 
     # Between 2012-2020 we actually added the methods generated below to the
diff --git a/lib/SNMP/Info/Layer3/ArubaCX.pm b/lib/SNMP/Info/Layer3/ArubaCX.pm
index fd4be14d..7526fb23 100644
--- a/lib/SNMP/Info/Layer3/ArubaCX.pm
+++ b/lib/SNMP/Info/Layer3/ArubaCX.pm
@@ -131,7 +131,7 @@ sub stack_info {
         }
         return sprintf("%s (stack of %d)", $modelname, $num_members);
     } else {
-        return undef;
+        return;
     }
 }
 
@@ -222,6 +222,8 @@ Subclass for devices running ArubaOS-CX
 
 =item SNMP::Info::Layer3
 
+=item SNMP::Info::IEEE802_Bridge
+
 =item SNMP::Info::IEEE802dot3ad
 
 =back
@@ -236,10 +238,12 @@ Subclass for devices running ArubaOS-CX
 
 =item Inherited Classes' MIBs
 
-See L<SNMP::Info::IEEE802dot3ad> for its own MIB requirements.
-
 See L<SNMP::Info::Layer3> for its own MIB requirements.
 
+See L<SNMP::Info::IEEE802_Bridge> for its own MIB requirements.
+
+See L<SNMP::Info::IEEE802dot3ad> for its own MIB requirements.
+
 =back
 
 =head1 GLOBALS
@@ -253,7 +257,7 @@ These are methods that return scalar value from SNMP
 If the device supports VSF stacking and is not in standalone mode, returns
 a string describing the switch family and the number of stack members.
 Example return value: '6300M (stack of 2)'. Will return undef when VSF is not
-supported or when the device is VSF standalone/
+supported or when the device is VSF standalone.
 
 =item $cx->model()
 
@@ -285,6 +289,10 @@ C<ARUBAWIRED-FAN-MIB>.
 
 See documentation in L<SNMP::Info::Layer3> for details.
 
+=head2 Globals imported from SNMP::Info::IEEE802_Bridge
+
+See documentation in L<SNMP::Info::IEEE802_Bridge> for details.
+
 =head2 Globals imported from SNMP::Info::IEEE802dot3ad
 
 See documentation in L<SNMP::Info::IEEE802dot3ad> for details.
@@ -321,6 +329,10 @@ L<SNMP::Info::IEEE8021_Bridge> at PBB 1.
 
 See documentation in L<SNMP::Info::Layer3> for details.
 
+=head2 Table Methods imported from SNMP::Info::IEEE802_Bridge
+
+See documentation in L<SNMP::Info::IEEE802_Bridge> for details.
+
 =head2 Table Methods imported from SNMP::Info::IEEE802dot3ad
 
 See documentation in L<SNMP::Info::IEEE802dot3ad> for details.
diff --git a/lib/SNMP/Info/Layer3/Ciena.pm b/lib/SNMP/Info/Layer3/Ciena.pm
index f897f537..6e026ff4 100644
--- a/lib/SNMP/Info/Layer3/Ciena.pm
+++ b/lib/SNMP/Info/Layer3/Ciena.pm
@@ -182,7 +182,21 @@ sub ps2_status {
     my $ps_status = $ciena->ps_status;
     return $ps_status->{'2'} if defined $ps_status->{'2'};
 }
+
+1;
+
+__END__
+
+=head1 NAME
+
+SNMP::Info::Layer3::Ciena - SNMP Interface to Ciena Devices
+
+=head1 AUTHORS
+
+pyro3d
+
 =head1 DESCRIPTION
+
 Subclass for Ciena Devices running SAOS
 
 =head2 Inherited Classes
@@ -323,3 +337,5 @@ Returns reference to hash of fans and their types (ex. fixed, modular, etc.)
 Returns reference to hash of fans and their status
 
 =back
+
+=cut