135/snmp-info
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use indirect syntax for new()

Browse Source
This commit is contained in:
Eric A. Miller
2018-03-22 00:15:06 -04:00
parent ddc5fd8c96
commit f6d0fb1d7e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/SNMP/Info.pm
View File

@@ -1277,7 +1277,7 @@ sub new {
} }
# Connects to device unless open session is provided. # Connects to device unless open session is provided.
$sess = new SNMP::Session( $sess = SNMP::Session->new(
'UseEnums' => 1, 'UseEnums' => 1,
%sess_args, 'RetryNoSuch' => $new_obj->{nosuch} %sess_args, 'RetryNoSuch' => $new_obj->{nosuch}
) unless defined $sess; ) unless defined $sess;
@@ -1339,7 +1339,7 @@ sub update {
delete $sess_args{BigInt}; delete $sess_args{BigInt};
delete $sess_args{MibDirs}; delete $sess_args{MibDirs};
my $sess = new SNMP::Session( my $sess = SNMP::Session->new(
'UseEnums' => 1, 'UseEnums' => 1,
%sess_args, 'RetryNoSuch' => $obj->{nosuch} %sess_args, 'RetryNoSuch' => $obj->{nosuch}
); );
@@ -4247,7 +4247,7 @@ sub _load_attr {
# partial fetch may strip the Module portion upon return. We need # partial fetch may strip the Module portion upon return. We need
# the match to make sure we didn't leave the table during getnext # the match to make sure we didn't leave the table during getnext
# requests # requests
my ($leaf) = $qual_leaf =~ /::(\w+)$/; my ($leaf) = $qual_leaf =~ /::(\w+)$/;
$self->debug() $self->debug()
@@ -4255,7 +4255,7 @@ sub _load_attr {
defined $partial ? "($partial)" : '', " : $oid" , defined $partial ? "($partial)" : '', " : $oid" ,
defined $partial ? ".$partial" : '', "\n"; defined $partial ? ".$partial" : '', "\n";
my $var = new SNMP::Varbind( [$qual_leaf, $partial] ); my $var = SNMP::Varbind->new( [$qual_leaf, $partial] );
# So devices speaking SNMP v.1 are not supposed to give out # So devices speaking SNMP v.1 are not supposed to give out
# data from SNMP2, but most do. Net-SNMP, being very precise # data from SNMP2, but most do. Net-SNMP, being very precise
@@ -4448,7 +4448,7 @@ sub snmp_connect_ip {
return if ( $ip eq '0.0.0.0' ) or ( $ip =~ /^127\./ ); return if ( $ip eq '0.0.0.0' ) or ( $ip =~ /^127\./ );
# Create session object # Create session object
my $snmp_test = new SNMP::Session( my $snmp_test = SNMP::Session->new(
'DestHost' => $ip, 'DestHost' => $ip,
'Community' => $comm, 'Community' => $comm,
'Version' => $ver 'Version' => $ver