update manpage

after reading netdisco/netdisco#693 and checking the code it seems layers() does not return l2 support.

while here add required mibs and move layers() manpage to globals, not table entries

Changes

@@ -171,7 +171,7 @@ Version 3.59 (2018-05-01)
 
   [BUG FIXES]
 
-  * Capture fan ans power supply status in L3::Huawei when description is
+  * Capture fan and power supply status in L3::Huawei when description is
     not available
 
 Version 3.58 (2018-04-29)
@@ -375,13 +375,13 @@ version 3.41 (2018-02-01)
 
   [BUG FIXES]
 
-  * Fixes to distriution metadata
+  * Fixes to distribution metadata
 
 version 3.40 (2018-01-28)
 
   [ENHANCEMENTS]
 
-  * #240 Support for CheckPoint devies through SNMP
+  * #240 Support for CheckPoint devices through SNMP
   * #240 Cisco SB switches fixup
   * #244 Add Adtran support
   * #241 Vyatta/VyOS support

lib/SNMP/Info.pm

@@ -1663,44 +1663,44 @@ sub device_type {
     # Hash for generic fallback to a device class if unable to determine using
     # the sysDescr regex.
     my %l3sysoidmap = (
-        9    => 'SNMP::Info::Layer3::Cisco',
-        11   => 'SNMP::Info::Layer2::HP',
-        18   => 'SNMP::Info::Layer3::BayRS',
-        42   => 'SNMP::Info::Layer3::Sun',
-        43   => 'SNMP::Info::Layer2::3Com',
-        45   => 'SNMP::Info::Layer2::Baystack',
-        171  => 'SNMP::Info::Layer3::DLink',
-        244  => 'SNMP::Info::Layer3::Lantronix',
-        311  => 'SNMP::Info::Layer3::Microsoft',
+        9     => 'SNMP::Info::Layer3::Cisco',
+        11    => 'SNMP::Info::Layer2::HP',
+        18    => 'SNMP::Info::Layer3::BayRS',
+        42    => 'SNMP::Info::Layer3::Sun',
+        43    => 'SNMP::Info::Layer2::3Com',
+        45    => 'SNMP::Info::Layer2::Baystack',
+        171   => 'SNMP::Info::Layer3::DLink',
+        244   => 'SNMP::Info::Layer3::Lantronix',
+        311   => 'SNMP::Info::Layer3::Microsoft',
         664   => 'SNMP::Info::Layer2::Adtran',
-        674  => 'SNMP::Info::Layer3::Dell',
-        1588 => 'SNMP::Info::Layer3::Foundry',
-        1872 => 'SNMP::Info::Layer3::AlteonAD',
-        1890 => 'SNMP::Info::Layer3::Redlion',
-        1916 => 'SNMP::Info::Layer3::Extreme',
-        1991 => 'SNMP::Info::Layer3::Foundry',
-        2011 => 'SNMP::Info::Layer3::Huawei',
-        2021 => 'SNMP::Info::Layer3::NetSNMP',
-        2272 => 'SNMP::Info::Layer3::Passport',
-        2620 => 'SNMP::Info::Layer3::CheckPoint',
-        2636 => 'SNMP::Info::Layer3::Juniper',
-        2925 => 'SNMP::Info::Layer1::Cyclades',
-        3076 => 'SNMP::Info::Layer3::Altiga',
-        3224 => 'SNMP::Info::Layer3::Netscreen',
-        3375 => 'SNMP::Info::Layer3::F5',
-        3417 => 'SNMP::Info::Layer3::BlueCoatSG',
-        3717 => 'SNMP::Info::Layer3::Genua',
-        4413 => 'SNMP::Info::Layer2::Ubiquiti',
-        4526 => 'SNMP::Info::Layer2::Netgear',
-        4874 => 'SNMP::Info::Layer3::ERX',
-        5624 => 'SNMP::Info::Layer3::Enterasys',
-        6027 => 'SNMP::Info::Layer3::Force10',
-        6141 => 'SNMP::Info::Layer3::Ciena',
-        6486 => 'SNMP::Info::Layer3::AlcatelLucent',
-        6527 => 'SNMP::Info::Layer3::Timetra',
-        6876 => 'SNMP::Info::Layer3::VMware',
-        8072 => 'SNMP::Info::Layer3::NetSNMP',
-        9303 => 'SNMP::Info::Layer3::PacketFront',
+        674   => 'SNMP::Info::Layer3::Dell',
+        1588  => 'SNMP::Info::Layer3::Foundry',
+        1872  => 'SNMP::Info::Layer3::AlteonAD',
+        1890  => 'SNMP::Info::Layer3::Redlion',
+        1916  => 'SNMP::Info::Layer3::Extreme',
+        1991  => 'SNMP::Info::Layer3::Foundry',
+        2011  => 'SNMP::Info::Layer3::Huawei',
+        2021  => 'SNMP::Info::Layer3::NetSNMP',
+        2272  => 'SNMP::Info::Layer3::Passport',
+        2620  => 'SNMP::Info::Layer3::CheckPoint',
+        2636  => 'SNMP::Info::Layer3::Juniper',
+        2925  => 'SNMP::Info::Layer1::Cyclades',
+        3076  => 'SNMP::Info::Layer3::Altiga',
+        3224  => 'SNMP::Info::Layer3::Netscreen',
+        3375  => 'SNMP::Info::Layer3::F5',
+        3417  => 'SNMP::Info::Layer3::BlueCoatSG',
+        3717  => 'SNMP::Info::Layer3::Genua',
+        4413  => 'SNMP::Info::Layer2::Ubiquiti',
+        4526  => 'SNMP::Info::Layer2::Netgear',
+        4874  => 'SNMP::Info::Layer3::ERX',
+        5624  => 'SNMP::Info::Layer3::Enterasys',
+        6027  => 'SNMP::Info::Layer3::Force10',
+        6141  => 'SNMP::Info::Layer3::Ciena',
+        6486  => 'SNMP::Info::Layer3::AlcatelLucent',
+        6527  => 'SNMP::Info::Layer3::Timetra',
+        6876  => 'SNMP::Info::Layer3::VMware',
+        8072  => 'SNMP::Info::Layer3::NetSNMP',
+        9303  => 'SNMP::Info::Layer3::PacketFront',
         10002 => 'SNMP::Info::Layer2::Ubiquiti',
         10418 => 'SNMP::Info::Layer1::Cyclades',
         12325 => 'SNMP::Info::Layer3::Pf',
@@ -1746,7 +1746,7 @@ sub device_type {
         3375  => 'SNMP::Info::Layer3::F5',
         4526  => 'SNMP::Info::Layer2::Netgear',
         5624  => 'SNMP::Info::Layer3::Enterasys',
-        6141 => 'SNMP::Info::Layer3::Ciena',
+        6141  => 'SNMP::Info::Layer3::Ciena',
         6486  => 'SNMP::Info::Layer3::AlcatelLucent',
         9303  => 'SNMP::Info::Layer3::PacketFront',
         10418 => 'SNMP::Info::Layer1::Cyclades',

lib/SNMP/Info/Layer3/PaloAlto.pm

@@ -129,6 +129,10 @@ Subclass for Palo Alto devices
 
 =over
 
+=item F<PAN-COMMON-MIB>
+
+=item F<PAN-PRODUCTS-MIB>
+
 =item Inherited Classes' MIBs
 
 See L<SNMP::Info::Layer3> for its own MIB requirements.
@@ -163,6 +167,17 @@ Returns the value of C<panSysSerialNumber.0>.
 
 =back
 
+=head2 Overrides
+
+=over
+
+=item $pa->layers()
+
+Returns 01001100. Palo Alto doesn't report layers, modified to reflect
+Layer 3,4,7 functionality.
+
+=back
+
 =head2 Globals imported from SNMP::Info::Layer3
 
 See documentation in L<SNMP::Info::Layer3> for details.
@@ -172,20 +187,8 @@ See documentation in L<SNMP::Info::Layer3> for details.
 These are methods that return tables of information in the form of a reference
 to a hash.
 
-=head2 Overrides
-
-=over
-
-=item $pa->layers()
-
-Returns 01001110.  Palo Alto doesn't report layers, modified to reflect
-Layer 2,3,4,7 functionality.
-
-=back
-
 =head2 Table Methods imported from SNMP::Info::Layer3
 
 See documentation in L<SNMP::Info::Layer3> for details.
 
-
 =cut

lib/SNMP/Info/Layer3/SonicWALL.pm

@@ -121,7 +121,7 @@ phishphreek@gmail.com
 
 =head1 DESCRIPTION
 
-Subclass for Generic SonicWALL Firewalls
+Subclass for SonicWALL Firewalls
 
 =head2 Inherited Classes
 
@@ -159,7 +159,7 @@ Returns C<'sonicwall'>
 
 =item $router->os()
 
-Returns C<'sonicos enhanded'> or C<'sonicos standard'> based on C<'snwlSysFirmwareVersion'>
+Returns C<'sonicos enhanced'> or C<'sonicos standard'> based on C<'snwlSysFirmwareVersion'>
 
 =item $router->os_ver()