#722 manual topology should not allow same left and right port/device

2020-06-29 14:42:06 +01:00
parent dc87a50076
commit 170ea64b7e
2 changed files with 4 additions and 0 deletions
--- a/1
+++ b/1
@@ -6,6 +6,7 @@

  [BUG FIXES]

+  * #722 manual topology should not allow same left and right port/device
  * #729 Discovery partially fails on invalid indexes

 2.045007 - 2020-06-05
--- a/lib/App/Netdisco/Web/Plugin/AdminTask/Topology.pm
+++ b/lib/App/Netdisco/Web/Plugin/AdminTask/Topology.pm
@@ -26,6 +26,9 @@ sub _sanity_ok {
    return 0 unless param('port1');
    return 0 unless param('port2');

+    return 0 if
+      (($dev1->addr eq $dev2->addr) and (param('port1') eq param('port2')));
+
    return 1;
 }