135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#935 Macsuck forces ports up/up - but a forwarding table may be present on a port that is down

Browse Source
This commit is contained in:
Oliver Gorwits
2022-10-18 12:49:24 +01:00
parent 4b04fdc588
commit 2cb2809dd9
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/App/Netdisco/Worker/Plugin/Macsuck/Nodes.pm
View File

@@ -32,6 +32,9 @@ register_worker({ phase => 'main', driver => 'snmp' }, sub {
$device->ports(undef, {prefetch => {neighbor_alias => 'device'}})->all};
my $interfaces = $snmp->interfaces;
my $reverse_interfaces = { reverse %{ $interfaces } }; # might squash but prob not
my $i_up = $snmp->i_up;
my $i_up_admin = $snmp->i_up_admin;
# get forwarding table data via basic snmp connection
my $fwtable = walk_fwtable($device, $interfaces, $device_ports);
@@ -60,8 +63,15 @@ register_worker({ phase => 'main', driver => 'snmp' }, sub {
# make sure this port is UP in netdisco (unless it's a lag master,
# because we can still see nodes without a functioning aggregate)
$device_ports->{$port}->update({up_admin => 'up', up => 'up'})
if not $device_ports->{$port}->is_master;
my $iid = $reverse_interfaces->{$port};
if ($iid and not $device_ports->{$port}->is_master) {
debug sprintf ' [%s] macsuck - updating port %s status : %s/%s',
$device->ip, $port, ($i_up_admin->{$iid} || '-'), ($i_up->{$iid} || '-');
$device_ports->{$port}->update({
up => $i_up->{$iid},
up_admin => $i_up_admin->{$iid},
});
}
foreach my $mac (keys %{ $fwtable->{$vlan}->{$port} }) {