135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

always log error from set_foo

Browse Source
This commit is contained in:
Oliver Gorwits
2012-12-03 22:59:18 +00:00
parent 3e3ceb59af
commit acb7bfe797
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Netdisco/lib/Netdisco/PortControl.pm
View File

@@ -20,7 +20,8 @@ sub _set_generic {
try { try {
# snmp connect using rw community # snmp connect using rw community
my $info = snmp_connect($ip) my $info = snmp_connect($ip)
or return (); or return ('error',
sprintf 'Failed to connect to device [%s] to update %s', $ip, $slot);
my $method = 'set_'. $slot; my $method = 'set_'. $slot;
my $rv = $info->$method($data); my $rv = $info->$method($data);
@@ -42,7 +43,9 @@ sub _set_generic {
# get device details from db # get device details from db
my $device = get_device($ip) my $device = get_device($ip)
or return (); or return ('error',
sprintf 'Updated %s on [%s] to [%s] but failed to update database',
$slot, $ip, $data);
# update netdisco DB # update netdisco DB
$device->update({$slot => $data}); $device->update({$slot => $data});