135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

html template fixups (#576)

Browse Source 
* none is not a valid value for min-width, so set it to zero

* these 2 "checked" if statements need a space in front of them,
else they will attach to the previous element

id="nd_showspeed"checked="checked"

* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

also, don't close select before we've gotten to the option tags

* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

also, don't close select before we've gotten to the option tags

* just to be sure put a space in front of these optional tags as well,

* $a is technically allowed but is considered not best practice
This commit is contained in:
nick n
2019-05-12 09:32:42 +02:00
committed by Oliver Gorwits
parent 90a7ee6b56
commit cd2a4b9362
12 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/App/Netdisco/Web/PortControl.pm
View File

@@ -31,14 +31,14 @@ ajax '/ajax/portcontrol' => require_any_role [qw(admin port_control)] => sub {
schema('netdisco')->txn_do(sub {
if (param('port')) {
my $a = "$action $subaction";
$a =~ s/-other$//;
$a =~ s/^portcontrol/port/;
my $act = "$action $subaction";
$act =~ s/-other$//;
$act =~ s/^portcontrol/port/;
schema('netdisco')->resultset('DevicePortLog')->create({
ip => param('device'),
port => param('port'),
action => $a,
action => $act,
username => session('logged_in_user'),
userip => request->remote_address,
reason => (param('reason') || 'other'),