3 Commits
Author SHA1 Message Date
Brian De WolfandOliver Gorwits 788d3ac26b dump sshcollector stderr into null (#396)
If SSH prints anything to stderr, it leaks out to the caller of sshcollect.
This change dumps it into /dev/null instead.
2018-04-28 11:43:39 +01:00
Brian De WolfandOliver Gorwits 2f2c9f6b26 Improve Palo Alto SSH Collector support (#397)
The PAN CLI tries to do friendly auto-completion things and makes the SSH
Collector fail sporadically.  This change uses the "set cli scripting-mode on"
command to calm down the PAN CLI and works around the extra echoed prompts that
get sent.

This change also adds collection of IPv6 neighbor information.
2018-04-28 11:43:01 +01:00
Brian De WolfandOliver Gorwits bebaaba626 fix sshcollector errors when devices are empty (#391)
While setting up an sshcollector, I found that the script doesn't handle an
arpless device very gracefully.  The log looks like:

	[46567] 2018-04-10 16:59:08  warn WARNING: no entries received from <IP>
	Can't use string ("1") as an ARRAY ref while "strict refs" in use at perl5/bin/netdisco-sshcollector line 114, <__ANONIO__> line 3.

This is fixed by making the process function always return the expected
structure, even if it's empty.  After this error, the following errors showed
up:

	[53232] 2018-04-10 17:06:15  warn WARNING: no entries received from <IP>
	[53210] 2018-04-10 17:06:15  info  [134.71.0.126] arpnip - retrieved 0 entries
	Use of uninitialized value in sprintf at perl5/bin/netdisco-sshcollector line 119, <__ANONIO__> line 3.
	[53210] 2018-04-10 17:06:15  info arpnip - processed  ARP Cache entries from 1 devices

This is because $stats{entry} only becomes an integer by being incremented, so
if there aren't any entries, it never exists.  This is fixed by starting it at 0.
2018-04-10 21:12:20 +01:00