PBP always return via an explicit return

Info/Bridge.pm

@@ -139,7 +139,7 @@ sub qb_fw_mac {
         my($fdb_id, $mac) = _qb_fdbtable_index($idx);
         $qb_fw_mac->{$idx} = $mac;
     }
-    $qb_fw_mac;
+    return $qb_fw_mac;
 }
 
 sub qb_i_vlan_t {

Info/Layer1.pm

@@ -110,6 +110,8 @@ sub vendor {
     return 'cisco' if ($descr =~ /(catalyst|cisco|ios)/i);
     return 'allied' if ($descr =~ /allied/i);
     return 'asante' if ($descr =~ /asante/i);
+    
+    return 'unknown';
 
 }
 

Info/Layer2/Aironet.pm

@@ -267,7 +267,8 @@ sub munge_cd11_txrate {
     my $txrates = shift;
     my @rates = unpack("C*", $txrates);
     map {$_ *= 0.5} @rates;
-    \@rates;
+
+    return \@rates;
 }
 
 # cd11 INDEX

Info/Layer2/C1900.pm

@@ -88,8 +88,8 @@ $VERSION = '1.09';
            %SNMP::Info::CDP::MUNGE,
          );
 
-sub bulkwalk_no         { 1; }
-sub cisco_comm_indexing { 1; }
+sub bulkwalk_no         { return 1; }
+sub cisco_comm_indexing { return 1; }
 
 sub vendor {
     return 'cisco';

Info/Layer2/C2900.pm

@@ -93,7 +93,7 @@ sub vendor {
 }
 
 sub cisco_comm_indexing {
-    1;
+    return 1;
 }
 
 sub i_duplex {

Info/Layer2/Catalyst.pm

@@ -141,7 +141,7 @@ sub bp_index {
 }
 
 sub cisco_comm_indexing {
-    1;
+    return 1;
 }
 
 sub interfaces {

Info/Layer2/Foundry.pm

@@ -204,7 +204,7 @@ sub vendor {
 
 # this hangs on a edgeiron24g
 # TODO: check by devicetype and deferr to SUPER if not bad device
-sub stp_p_state { undef; }
+sub stp_p_state { return undef; }
 
 1;
 __END__

Info/Layer3.pm

@@ -273,6 +273,8 @@ sub vendor {
 
     return 'cisco' if ($descr =~ /(cisco|\bios\b)/i);
     return 'foundry' if ($descr =~ /foundry/i);
+    
+    return 'unknown';
 
 }
 

Info/Layer3/C3550.pm

@@ -211,12 +211,12 @@ sub set_i_duplex_admin {
        return $c3550->set_p_duplex($duplexes{$duplex}, $iid);
     }
     else {
-        $c3550->SUPER::set_i_duplex_admin;
+        return $c3550->SUPER::set_i_duplex_admin;
     }
 }
 
 sub cisco_comm_indexing {
-    1;
+    return 1;
 }
 
 1;

Info/Layer3/C4000.pm

@@ -119,10 +119,10 @@ sub fan {
 	$s = ", ";
     }
     return if ($s eq "");
-    $ret;
+    return $ret;
 }
 
-sub cisco_comm_indexing { 1; }
+sub cisco_comm_indexing { return 1; }
 
 1;
 __END__

Info/Layer3/C6500.pm

@@ -108,7 +108,7 @@ sub vendor {
     return 'cisco';
 }
 
-sub cisco_comm_indexing { 1; }
+sub cisco_comm_indexing { return 1; }
 
 #  Newer versions use the ETHERLIKE-MIB to report operational duplex.
 
@@ -188,7 +188,7 @@ sub set_i_duplex_admin {
        return $c6500->set_p_duplex($duplexes{$duplex}, $iid);
     }
     else {
-        $c6500->SUPER::set_i_duplex_admin;
+        return $c6500->SUPER::set_i_duplex_admin;
     }
 }
 

Info/Layer3/Cisco.pm

@@ -122,7 +122,7 @@ sub i_vlan {
 			}
 		}
 	}
-	\%i_vlan;
+	return \%i_vlan;
 }
 
 1;

Info/Layer3/Extreme.pm

@@ -223,7 +223,7 @@ sub fan {
         $s = ", ";
     }
     return if ($s eq "");
-    $ret;
+    return $ret;
 }
 
 # Newer versions of the Extreme firmware have vendor-specific tables
@@ -291,7 +291,7 @@ sub _if2tag {
             $if2tag{$if} = -$global_id->{$if} if ($if2tag{$if} == -1 && defined($global_id->{$if}));
         }
     }
-    \%if2tag;
+    return \%if2tag;
 }
 
 # No partial support in v_name or v_index, because the obivous partial

Info/Layer3/Juniper.pm

@@ -117,7 +117,7 @@ sub i_vlan {
 			}
 		}
 	}
-	\%i_vlan;
+	return \%i_vlan;
 }
 
 1;

Info/Layer3/N1600.pm

@@ -71,8 +71,6 @@ $VERSION = '1.09';
 
 # Method OverRides
 
-sub bulkwalk_no { 1; }
-
 sub model {
     my $n1600 = shift;
     my $id = $n1600->id();