after reading netdisco/netdisco#693 and checking the code it seems layers() does not return l2 support.
while here add required mibs and move layers() manpage to globals, not table entries
* Retrieve Serial Number and device type for CheckPoint devices at right place in MIB
* Retrieve Serial Number and device type for CheckPoint
* Retrieve Serial Number and device type for CheckPoint
* Test not correct with cache data
* revert fix 2 of commit 78119d6, breaks devices that report a port name
6 chars long
* and remove test case for the "packed mac" special case
* and mention cdp fix in changelog
ran this for over 2 months and did not have any regressions on my gear.
also fixed all reported errors by these, but work is still needed.
stuff like
sub thingy {
my $thing = shift;
my $stuff = $thing->os_ver();
if ($stuff =~ /check/) {
-> newer perls (or perhaps just my config somehow) seems to prefer
if ((defined $stuff) && ($stuff =~ /check/)) {
instead.
or perhaps i just don't understand autoloader magic & return type nuances.
* ident
* remove $Id$ tags from rcs software which has been retired
* make an effort to sync required mib docs with actual code
* sync even more docs with what code actually does
* some whitespace nits
* fixup example to use snmpv2 for all but the most ancient devices
* remove blurb to find more specific snmp::info classes for classes
which alrdy are as specific as they can get (eg snmp::info::layer3::vmware
doesn't need info on to find a specific module since there ain't none)
* rename all sub {vendor} strings to lowercase vendor, if cisco, juniper
and arista can be lowercase, so can be all the rest.
* fix tests
* spread some use warnings around
* use $ instead of @
* remove defines that are included via parent classes
* use strict + warnings
* remove alrdy included modules
* add comma after last list item
* typos
* mibs are found in our mib repo, not on the cisco site
* documentation fixes
add hook::lexwrap to testdeps (#341)
also use #!/usr/bin/env perl instead of #!/usr/bin/perl
can't see a related change to perl5.30 that could cause this however
having a go at intellij + perl support & cygwin. working surprisingly well.
exclude it's project configuration files. also fix 3 typos found when getting this to work.
